The $re changes everytime through the loops, so we can't optimise it.

This bug meant that only the first regex in the INC and EXCL lists
was ever used.

diff --git a/contrib/plugins/spong-server/data_sendmsg b/contrib/plugins/spong-server/data_sendmsg
index 9f74ffb1080dc8bdacfff2ef819ab5f5623b7a63..1d57aaefe5518a5251ad4e15a73c5e2982d47eab 100644 (file)
--- a/contrib/plugins/spong-server/data_sendmsg
+++ b/contrib/plugins/spong-server/data_sendmsg
@@ -38,13 +38,13 @@ sub data_sendmsg {
 
    # Check the list of hosts to exclude
    foreach my $re (@SENDMSG_EXCL_HOSTS) {
 
    # Check the list of hosts to exclude
    foreach my $re (@SENDMSG_EXCL_HOSTS) {

-      if ( $host =~ /$re/o ) { return; }  # If we get a hit, return
+      if ( $host =~ /$re/ ) { return; }  # If we get a hit, return

    }
 
    # Check the lists of hosts to include
    my $hit=0;
    foreach my $re (@SENDMSG_INC_HOSTS) {
    }
 
    # Check the lists of hosts to include
    my $hit=0;
    foreach my $re (@SENDMSG_INC_HOSTS) {

-      if ( $host =~ /$re/o ) { $hit=1; last; } # If we get a hit, set flag
+      if ( $host =~ /$re/ ) { $hit=1; last; } # If we get a hit, set flag

    }
    return unless $hit;  # Return unless we got a hit
 
    }
    return unless $hit;  # Return unless we got a hit